From 36f13cb5af20505b45b32201d9525af2495a2015 Mon Sep 17 00:00:00 2001 From: LuckyLaszlo Date: Mon, 16 Jan 2023 18:00:19 +0100 Subject: [PATCH 1/4] fetchUser/Avatar() with optionnal username param + miscs smalls changes --- srcs/requirements/svelte/api_front/.env | 2 - .../api_front/src/pages/game/Game.svelte | 4 +- .../src/pages/game/GameSpectator.svelte | 6 +- .../svelte/api_front/src/pieces/Canvas.svelte | 112 ------------------ .../src/pieces/GenerateUserDisplay.svelte | 4 +- .../svelte/api_front/src/pieces/utils.ts | 24 ++-- 6 files changed, 21 insertions(+), 131 deletions(-) delete mode 100644 srcs/requirements/svelte/api_front/.env delete mode 100644 srcs/requirements/svelte/api_front/src/pieces/Canvas.svelte diff --git a/srcs/requirements/svelte/api_front/.env b/srcs/requirements/svelte/api_front/.env deleted file mode 100644 index 1b450684..00000000 --- a/srcs/requirements/svelte/api_front/.env +++ /dev/null @@ -1,2 +0,0 @@ -WEBSITE_HOST=transcendance -WEBSITE_PORT=8080 diff --git a/srcs/requirements/svelte/api_front/src/pages/game/Game.svelte b/srcs/requirements/svelte/api_front/src/pages/game/Game.svelte index 3cf3590f..1b28fd70 100644 --- a/srcs/requirements/svelte/api_front/src/pages/game/Game.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/game/Game.svelte @@ -14,8 +14,8 @@ let user; let allUsers; - let playerOneAvatar; - let playerTwoAvatar; + let playerOneAvatar = ""; + let playerTwoAvatar = ""; //Game's stuff const options = new pong.InitOptions(); diff --git a/srcs/requirements/svelte/api_front/src/pages/game/GameSpectator.svelte b/srcs/requirements/svelte/api_front/src/pages/game/GameSpectator.svelte index 033c25eb..9d538c88 100644 --- a/srcs/requirements/svelte/api_front/src/pages/game/GameSpectator.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/game/GameSpectator.svelte @@ -5,13 +5,13 @@ import MatchListElem from "../../pieces/MatchListElem.svelte"; import type { Match } from "../../pieces/Match"; - import { fetchUser, fetchAllUsers, fetchAvatar } from "../../pieces/utils"; + import { fetchAvatar } from "../../pieces/utils"; import * as pongSpectator from "./client/pongSpectator"; import { gameState } from "./client/ws"; - let playerOneAvatar; - let playerTwoAvatar; + let playerOneAvatar = ""; + let playerTwoAvatar = ""; //Game's stuff const gameAreaId = "game_area"; diff --git a/srcs/requirements/svelte/api_front/src/pieces/Canvas.svelte b/srcs/requirements/svelte/api_front/src/pieces/Canvas.svelte deleted file mode 100644 index 5fd1264a..00000000 --- a/srcs/requirements/svelte/api_front/src/pieces/Canvas.svelte +++ /dev/null @@ -1,112 +0,0 @@ - - - - - diff --git a/srcs/requirements/svelte/api_front/src/pieces/GenerateUserDisplay.svelte b/srcs/requirements/svelte/api_front/src/pieces/GenerateUserDisplay.svelte index 95fcc5ee..d8a9904d 100644 --- a/srcs/requirements/svelte/api_front/src/pieces/GenerateUserDisplay.svelte +++ b/srcs/requirements/svelte/api_front/src/pieces/GenerateUserDisplay.svelte @@ -62,11 +62,11 @@
- {#if user !== undefined} + {#if user}
- default user icon + user avatar
{errors.avatar}
{user.username}
Rank: diff --git a/srcs/requirements/svelte/api_front/src/pieces/utils.ts b/srcs/requirements/svelte/api_front/src/pieces/utils.ts index bc498c49..e193b039 100644 --- a/srcs/requirements/svelte/api_front/src/pieces/utils.ts +++ b/srcs/requirements/svelte/api_front/src/pieces/utils.ts @@ -1,7 +1,12 @@ -export async function fetchAvatar(username: string) +export async function fetchAvatar(username?: string) { - return fetch(`http://${process.env.WEBSITE_HOST}:${process.env.WEBSITE_PORT}/api/v2/user/avatar?username=${username}`) + let url = `http://${process.env.WEBSITE_HOST}:${process.env.WEBSITE_PORT}/api/v2/user/avatar`; + if (username) { + url += `?username=${username}`; + } + + return fetch(url) .then((response) => { if (!response.ok) { throw new Error("HTTP " + response.status); @@ -17,18 +22,20 @@ export async function fetchAvatar(username: string) }); } -export async function fetchUser() +export async function fetchUser(username?: string) { - return fetch(`http://${process.env.WEBSITE_HOST}:${process.env.WEBSITE_PORT}/api/v2/user`) + let url = `http://${process.env.WEBSITE_HOST}:${process.env.WEBSITE_PORT}/api/v2/user`; + if (username) { + url += `?username=${username}`; + } + + return fetch(url) .then((response) => { if (!response.ok) { throw new Error("HTTP " + response.status); } return response.json(); }) - .then((body) => { - return body; - }) .catch((error) => { console.log("catch fetchUser: ", error); return null; @@ -44,9 +51,6 @@ export async function fetchAllUsers() } return response.json(); }) - .then((body) => { - return body; - }) .catch((error) => { console.log("catch fetchAllUsers: ", error); return []; From 314fa10cffd3c2a00543532957798e298a37ac9d Mon Sep 17 00:00:00 2001 From: LuckyLaszlo Date: Mon, 16 Jan 2023 18:03:08 +0100 Subject: [PATCH 2/4] fetch() changes in all svelte + miscs front refactoring --- .../api_front/src/pages/SplashPage.svelte | 46 +- .../src/pages/TwoFactorAuthentication.svelte | 87 ++-- .../api_front/src/pages/game/Ranking.svelte | 53 +- .../src/pages/profile/ProfileDisplay.svelte | 18 +- .../profile/ProfileDisplayOneUser.svelte | 34 +- .../src/pages/profile/ProfileSettings.svelte | 154 +++--- .../src/pages/profile/ProfileUsers.svelte | 470 ++++++++++-------- .../api_front/src/pieces/DisplayAUser.svelte | 29 +- .../svelte/api_front/src/pieces/Header.svelte | 55 +- 9 files changed, 522 insertions(+), 424 deletions(-) diff --git a/srcs/requirements/svelte/api_front/src/pages/SplashPage.svelte b/srcs/requirements/svelte/api_front/src/pages/SplashPage.svelte index c944f34e..c57a677c 100644 --- a/srcs/requirements/svelte/api_front/src/pages/SplashPage.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/SplashPage.svelte @@ -1,30 +1,36 @@ diff --git a/srcs/requirements/svelte/api_front/src/pages/TwoFactorAuthentication.svelte b/srcs/requirements/svelte/api_front/src/pages/TwoFactorAuthentication.svelte index be30e387..cbf4d74c 100644 --- a/srcs/requirements/svelte/api_front/src/pages/TwoFactorAuthentication.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/TwoFactorAuthentication.svelte @@ -1,44 +1,59 @@ diff --git a/srcs/requirements/svelte/api_front/src/pages/game/Ranking.svelte b/srcs/requirements/svelte/api_front/src/pages/game/Ranking.svelte index 35fc66ee..033da320 100644 --- a/srcs/requirements/svelte/api_front/src/pages/game/Ranking.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/game/Ranking.svelte @@ -1,28 +1,37 @@ @@ -41,18 +50,18 @@ - {#each allUsers as user, i} + {#each allUsersRanking as userRanking, i} {i + 1} - {#if user.username === currentUser.username} - {user.username} [You] + {#if userRanking.username === user.username} + {userRanking.username} [You] {:else} - {user.username} + {userRanking.username} {/if} - {user.stats.winGame} - {user.stats.loseGame} - {user.stats.drawGame} - {user.stats.totalGame} + {userRanking.stats.winGame} + {userRanking.stats.loseGame} + {userRanking.stats.drawGame} + {userRanking.stats.totalGame} {/each} diff --git a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplay.svelte b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplay.svelte index d1b7c125..0b537349 100644 --- a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplay.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplay.svelte @@ -1,19 +1,17 @@ @@ -21,7 +19,7 @@
- {#if user !== undefined} + {#if user} {:else} diff --git a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplayOneUser.svelte b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplayOneUser.svelte index 537c8646..898b75ce 100644 --- a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplayOneUser.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileDisplayOneUser.svelte @@ -1,32 +1,25 @@
-{#if user !== undefined} - +{#if oneUser} + {:else}

Sorry

Failed to load user {params.username}
@@ -35,4 +28,3 @@
- diff --git a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileSettings.svelte b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileSettings.svelte index 738dd392..e5822e3d 100644 --- a/srcs/requirements/svelte/api_front/src/pages/profile/ProfileSettings.svelte +++ b/srcs/requirements/svelte/api_front/src/pages/profile/ProfileSettings.svelte @@ -1,81 +1,89 @@ @@ -239,7 +301,7 @@