Client struct, signal wip, refactoring

Makefile

@@ -13,7 +13,7 @@ VPATH  = $(DIR_SRCS)
 DIR_SRCS =	srcs
 
 HEADERS_D = ./srcs
-HEADERS = Webserv.hpp
+HEADERS = Webserv.hpp Client.hpp Server.hpp
 
 DEPENDENCIES =	$(HEADERS:%=$(HEADERS_D)/%)
 

srcs/Client.hpp

@@ -0,0 +1,27 @@
+
+#ifndef CLIENT_HPP
+# define CLIENT_HPP
+
+# include <iostream>
+# include <string>
+# include <map>
+
+class Client
+{
+	public:
+		// Client(Placeholder);
+		// Client();
+		// Client(Client const &src);
+		// ~Client();
+		// Client &operator=(Client const &rhs);
+
+		int	fd;
+		std::string	raw_request;
+		std::map<std::string, std::string>	request;
+		std::map<std::string, std::string>	response;
+
+	private:
+
+};
+
+#endif

srcs/Server.hpp

@@ -0,0 +1,32 @@
+/* ************************************************************************** */
+/*                                                                            */
+/*                                                        :::      ::::::::   */
+/*   Server.hpp                                         :+:      :+:    :+:   */
+/*                                                    +:+ +:+         +:+     */
+/*   By: lperrey <lperrey@student.42.fr>            +#+  +:+       +#+        */
+/*                                                +#+#+#+#+#+   +#+           */
+/*   Created: 2022/07/24 12:11:07 by lperrey           #+#    #+#             */
+/*   Updated: 2022/07/24 12:11:13 by lperrey          ###   ########.fr       */
+/*                                                                            */
+/* ************************************************************************** */
+
+#ifndef SERVER_HPP
+# define SERVER_HPP
+
+# include <iostream>
+# include <string>
+
+class Server
+{
+	public:
+		// Server(Placeholder);
+		// Server();
+		// Server(Server const &src);
+		// ~Server();
+		// Server &operator=(Server const &rhs);
+
+	private:
+
+};
+
+#endif

srcs/Webserv.cpp

@@ -1,9 +1,15 @@
 
 #include "Webserv.hpp"
 
+int	g_last_signal;
+void	signal_handler(int signum)
+{
+	g_last_signal = signum;
+}
+
 Webserv::Webserv()
 {
-	std::cout << "Server init\n";
+	std::cerr << "Server init\n";
 
 	_epfd = ::epoll_create1(0); // (EPOLL_CLOEXEC) for CGI fork ?
 	if (_epfd == -1)
@@ -11,6 +17,9 @@ Webserv::Webserv()
 		std::perror("err epoll_create1(): ");
 		throw std::runtime_error("Epoll init");
 	}
+
+	std::signal(SIGPIPE, signal_handler);
+	// std::signal(SIGINT, signal_handler);
 }
 
 /* Webserv::Webserv(Webserv const &src)
@@ -22,7 +31,8 @@ Webserv::~Webserv()
 {
 	close(_socket_fd);
 	close(_epfd);
-	std::cout << "Server destroyed\n";
+	_close_all_clients();
+	std::cerr << "Server destroyed\n";
 }
 
 /* Webserv &	Webserv::operator=(Webserv const &rhs)
@@ -45,45 +55,44 @@ void	Webserv::init_virtual_servers() // ADD config param
 	_bind(_socket_fd, 80);
 	_listen(_socket_fd, 512); // 512 arbitrary
 
-	struct epoll_event	ev;
+	if (_epoll_update(_socket_fd, EPOLLIN, EPOLL_CTL_ADD) == -1)
-	std::memset(&ev, 0, sizeof ev);
-	ev.events = EPOLLIN;
-	ev.data.fd = _socket_fd;
-	if (::epoll_ctl(_epfd, EPOLL_CTL_ADD, _socket_fd, &ev) == -1)
-	{
-		std::perror("err epoll_ctl(): ");
 		throw std::runtime_error("Socket init");
-	}
 }
 
 void	Webserv::start()
 {
-	std::cout << "Server started\n";
+	std::cerr << "Server started\n";
 	struct epoll_event	events[MAX_EVENTS];
 	int	nfds;
 	int	i;
 	int	count_loop = 0;
-	std::cout << ++count_loop << "----loop epoll()\n";
+	std::cerr << ++count_loop << "----loop epoll()\n";
 
 	while ( (nfds = ::epoll_wait(_epfd, events, MAX_EVENTS, TIMEOUT)) != -1)
 	{
 		if (nfds == 0)
 		{
-			(void)0;
+			if (!_clients.empty())
-			// TODO : parcourir les "Clients" encore ouvert et les close() tous
+			{
+				std::cerr << "Timeout " << TIMEOUT << "ms\n";
+				_close_all_clients();
+			}
 		}
+
 		i = 0;
 		while (i < nfds)
 		{
+			// if ((events[i].data.u32 == SERVER_FD) && (events[i].events & EPOLLIN)) // Dont work, see "SERVER_FD" define
 			if ((events[i].data.fd == _socket_fd) && (events[i].events & EPOLLIN))
 				_accept_connection(events[i].data.fd);
 			else if (events[i].events & EPOLLIN)
-				_read_request(events[i].data.fd);
+				_read_request(static_cast<Client*>(events[i].data.ptr));
 			else if (events[i].events & EPOLLOUT)
-				_send_response(events[i].data.fd);
+				_send_response(static_cast<Client*>(events[i].data.ptr));
 			++i;
+			_actual_client = NULL;
 		}
-		std::cout << ++count_loop << "----loop epoll()\n";
+		std::cerr << ++count_loop << "----loop epoll()\n";
 	}
 
 	if (nfds == -1)
@@ -97,6 +106,164 @@ void	Webserv::start()
   ///////////////////////
  // Private Functions //
 
+void	Webserv::_accept_connection(int fd)
+{
+	struct sockaddr_in	addr;
+	socklen_t 			addr_len;
+	int					accepted_fd;
+
+	std::cerr << "accept()\n";
+	addr_len = sizeof addr;
+	accepted_fd = ::accept(fd, (sockaddr*)&addr, &addr_len);
+	if (accepted_fd == -1)
+	{
+		std::perror("err accept(): ");
+		return;
+	}
+	::fcntl(accepted_fd, F_SETFL, O_NONBLOCK);
+
+	_clients.push_back(Client());
+	_clients.back().fd = accepted_fd;
+
+	_epoll_update(accepted_fd, EPOLLIN, EPOLL_CTL_ADD, &_clients.back());
+}
+
+	 //////////
+	// READ //
+void	Webserv::_read_request(Client *client)
+{
+	char	buf[BUFSIZE+1];
+	ssize_t	ret;
+	_actual_client = client;
+
+	std::cerr << "recv()\n";
+	ret = ::recv(client->fd, buf, BUFSIZE, 0);
+	if (ret == -1)
+	{
+		std::perror("err recv(): ");
+		return;
+	}
+	/*
+	if (ret == BUFSIZE)
+		// send error like "request too long" to client
+	*/
+
+	buf[ret] = '\0';
+	client->raw_request.append(buf);
+
+	_epoll_update(client->fd, EPOLLOUT, EPOLL_CTL_MOD, client);
+}
+
+	 ///////////
+	// WRITE //
+void	Webserv::_send_response(Client *client)
+{
+	ssize_t	ret;
+	_actual_client = client;
+
+	std::cerr << "send()\n";
+	std::cerr << "RAW_REQUEST\n|\n" << client->raw_request << "|\n";
+
+	ret = ::send(client->fd, MSG_TEST, sizeof MSG_TEST - 1, 0);
+	if (ret == -1)
+	{
+		std::perror("err send(): ");
+		if (g_last_signal)
+			_handle_last_signal();
+		return ;
+	}
+
+	// if (client->raw_request.find("Connection: keep-alive") == std::string::npos)
+		_close_client(client->fd);
+	// else
+	// 	_epoll_update(client->fd, EPOLLIN, EPOLL_CTL_MOD, client);
+
+	client->raw_request.clear();
+}
+
+
+	 ////////////////////
+	// Misc functions //
+
+int	Webserv::_epoll_update(int fd, uint32_t events, int op)
+{
+	struct epoll_event	ev;
+	std::memset(&ev, 0, sizeof ev);
+	ev.events = events;
+	ev.data.fd = fd;
+	if (::epoll_ctl(_epfd, op, fd, &ev) == -1)
+	{
+		std::perror("err _epoll_update(): ");
+		return (-1);
+	}
+	return (0);
+}
+
+int	Webserv::_epoll_update(int fd, uint32_t events, int op, void *ptr)
+{
+	struct epoll_event	ev;
+	std::memset(&ev, 0, sizeof ev);
+	ev.events = events;
+	ev.data.ptr = ptr;
+	if (::epoll_ctl(_epfd, op, fd, &ev) == -1)
+	{
+		std::perror("err _epoll_update(): ");
+		return (-1);
+	}
+	return (0);
+}
+
+void	Webserv::_handle_last_signal()
+{
+	if (g_last_signal == SIGPIPE)
+	{
+		std::cerr << "SIGPIPE\n";
+		if (_actual_client)
+		{
+			_close_client(_actual_client->fd);
+			_actual_client = NULL;
+		}
+	}
+	// else if (g_last_signal == SIGINT)
+	// {
+	// }
+	g_last_signal = 0;
+}
+
+void	Webserv::_close_client(int fd)
+{
+	std::vector<Client>::iterator	it = _clients.begin();
+	while (it != _clients.end())
+	{
+		if (it->fd == fd)
+		{
+			if (::close(fd) == -1)
+				std::perror("err close(): ");
+			else
+				std::cerr << "close fd " << fd << "\n";
+			_clients.erase(it);
+			break;
+		}
+		++it;
+	}
+}
+
+void	Webserv::_close_all_clients()
+{
+	while (!_clients.empty())
+	{
+		if (::close(_clients.back().fd) == -1)
+			std::perror("err close(): ");
+		else
+			std::cerr << "close fd " << _clients.back().fd << "\n";
+		_clients.pop_back();
+	}
+}
+
+
+	 ////////////////////
+	// Init functions //
+
 void	Webserv::_bind(int socket_fd, in_port_t port)
 {
 	// cast invalid ? how to ?
@@ -123,64 +290,3 @@ void	Webserv::_listen(int socket_fd, unsigned int max_connections)
 		throw std::runtime_error("Socket listen");
 	}
 }
-
-void	Webserv::_accept_connection(int fd)
-{
-	struct sockaddr_in	addr;
-	socklen_t 			addr_len;
-	int					accepted_fd;
-
-	std::cout << "accept()\n";
-	addr_len = sizeof addr;
-	accepted_fd = ::accept(fd, (sockaddr*)&addr, &addr_len);
-	if (accepted_fd == -1)
-	{
-		std::perror("err accept(): ");
-		return;
-	}
-	::fcntl(accepted_fd, F_SETFL, O_NONBLOCK);
-
-	struct epoll_event	ev;
-	std::memset(&ev, 0, sizeof ev);
-	ev.events = EPOLLIN;
-	ev.data.fd = accepted_fd;
-	if (::epoll_ctl(_epfd, EPOLL_CTL_ADD, accepted_fd, &ev) == -1)
-		std::perror("err accept() epoll_ctl(): ");
-}
-
-void	Webserv::_read_request(int fd)
-{
-	std::cout << "recv()\n";
-	_read_ret = ::recv(fd, _buf, BUFSIZE, 0);
-	if (_read_ret == -1)
-	{
-		std::perror("err recv(): ");
-		if (::send(fd, MSG_BOUNCE, sizeof MSG_BOUNCE - 1, 0) == -1)
-			std::perror("err send(): ");
-
-		::close(fd);
-		return;
-	}
-	/*
-	if (_read_ret == BUFSIZE)
-		// send error like "request too long" to client
-	*/
-	_buf[_read_ret] = '\0';
-
-	struct epoll_event	ev;
-	std::memset(&ev, 0, sizeof ev);
-	ev.events = EPOLLOUT;
-	ev.data.fd = fd;
-	if (::epoll_ctl(_epfd, EPOLL_CTL_MOD, fd, &ev) == -1)
-		std::perror("err accept() epoll_ctl(): ");
-}
-
-void	Webserv::_send_response(int fd)
-{
-	std::cout << "send()\n";
-	if (::send(fd, _buf, _read_ret, 0) == -1)
-		std::perror("err send(): ");
-	if (::send(fd, MSG_TEST, sizeof MSG_TEST - 1, 0) == -1)
-		std::perror("err send(): ");
-	::close(fd);
-}

srcs/Webserv.hpp

@@ -2,14 +2,15 @@
 #ifndef WEBSERV_HPP
 # define WEBSERV_HPP
 
+# include <iostream> // cout, cin
 # include <string>
 # include <map>
+# include <vector>
 # include <cerrno> // errno
 # include <cstdio> // perror
 # include <exception>
 # include <stdexcept>
 # include <unistd.h> // close
-# include <iostream> // cout, cin
 # include <cstring> // memset
 
 # include <sys/socket.h> // socket, accept, listen, send, recv, bind, connect, setsockopt, getsockname
@@ -20,11 +21,33 @@
 # include <sys/epoll.h> // epoll
 # include <fcntl.h> // fcntl
 
-#define BUFSIZE 8192
+# include "Client.hpp"
-#define TIMEOUT 3000
+# include "Server.hpp"
-#define MAX_EVENTS 42 // arbitrary
+# include <csignal> // signal
-#define MSG_TEST "Le Webserv / 20 =D\n"
+
-#define MSG_BOUNCE "bounced properly ;)\n" // placeholder
+# define BUFSIZE 8192
+# define TIMEOUT 3000
+# define MAX_EVENTS 42 // arbitrary
+# define MSG_TEST "Le Webserv / 20 =D\n"
+
+
+// ev.data.u32 filled with tag constant "SERVER_FD/CLIENT_FD"
+// dont work because ev.data is an "union",
+// so we can only use one variable (fd, ptr, u32 or u64)
+	// ev.data.u32 = SERVER_FD;
+
+/* enum  // WIP test
+{
+	SERVER_FD = 1,
+	CLIENT_FD
+};
+
+struct	s // WIP test
+{
+	int	fd;
+	Client	*ptr;
+};
+ */
 
 class Webserv
 {
@@ -38,20 +61,26 @@ class Webserv
 		void	start();
 
 	private:
-		int	_socket_fd; // TODO: replace with vector of "Server" struct
 		int	_epfd;
+		int	_socket_fd; // temp, to replace with std::vector<Server>
+		// std::vector<Server>	_servers;
+		std::vector<Client>	_clients;
 
-		// WIP global buffer. Need one variable set per "Client"
+		void	_accept_connection(int fd);
-		char	_buf[BUFSIZE+1];
+		void	_read_request(Client *client);
-		ssize_t	_read_ret;
+		void	_send_response(Client *client);
-		std::map<std::string, std::string>	_request;
+
-		std::map<std::string, std::string>	_response;
+		int		_epoll_update(int fd, uint32_t events, int op);
+		int		_epoll_update(int fd, uint32_t events, int op, void *ptr);
+
+		void	_handle_last_signal();
+		// void	_signal_handler(int signum); // invalide dans une class
+		Client*	_actual_client;
+		void	_close_client(int fd);
+		void	_close_all_clients();
 
 		void	_bind(int socket_fd, in_port_t port);
 		void	_listen(int socket_fd, unsigned int max_connections);
-		void	_accept_connection(int fd);
-		void	_read_request(int fd);
-		void	_send_response(int fd);
 };
 
 #endif

srcs/main.cpp

@@ -2,7 +2,7 @@
 #include <iostream>
 #include <exception>
 #include <stdexcept>
-#include <Webserv.hpp>
+#include "Webserv.hpp"
 
 int	main(void)
 {