From 847f969a53fd23006e3e81d329cbec7918dfd795 Mon Sep 17 00:00:00 2001 From: hugo LAMY Date: Fri, 14 Mar 2025 13:16:12 +0100 Subject: [PATCH] tmp broken --- module05/ex00/adc.c | 5 +++-- module05/ex00/main.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/module05/ex00/adc.c b/module05/ex00/adc.c index fb37341..968f3cb 100644 --- a/module05/ex00/adc.c +++ b/module05/ex00/adc.c @@ -19,8 +19,9 @@ void adc_init(uint8_t prescaler_value) { uint16_t adc_read(uint8_t channel) { CLEAR(PRR, PRADC); // 24.3 : ensure power reduction is disabled for ADC, (10.11.3 : PRR – Power Reduction Register) ADMUX = (ADMUX & 0b11110000) | (channel & 0b1111); // Table 24-4 : Select ADC channel, (Table 14-6 : alternate function for RV1 on PC0 -> ADC0) - // ADMUX |= (1 << ADLAR); // Enable left adjust result + // ADMUX |= (1 << ADLAR); // 24.9.3 : enable left adjust result ADCSRA |= (1 << ADSC); // 24.9.2 : Start conversion, ADSC: ADC Start Conversion while (ADCSRA & (1 << ADSC)); // Wait for completion - return ADCH; // TODO: p247, read ADCH when left adjusted to only read 8 bits + // return ADCH; // 24.9.3 : ADC updated only when ADCH is read, not ADCL, so for 8 bits precision uses left adjust result to only read ADCH + return ADC; } diff --git a/module05/ex00/main.c b/module05/ex00/main.c index 531d078..9bd1a3e 100644 --- a/module05/ex00/main.c +++ b/module05/ex00/main.c @@ -22,7 +22,7 @@ int main() { while(1) { uint16_t value = adc_read(0); // Read from ADC0 (A0) - int_to_hex_string(value, buffer, 2); + int_to_hex_string(value, buffer, 3); uart_printstr_endl(buffer); _delay_ms(20); // Wait 20ms }